Code structure #83
Merged
Code structure #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmarwick
reviewed
Jun 27, 2019
|
I rarely use branches, but it looks like I could merge this without wrecking anything, so that's a relief! Thanks again for all your work organising those functions. It will be easier to maintain now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the CRAN release of rrtools (#75), @benmarwick and I decided to restructure its code files to increase the general readability and maintainability. This PR contains a first draft of a new file structure.
What's new:
hello.Rwas divided into several code files. One file (core_...) for each main function of the package.:::dependencies -- were reorganized in thematic files (helpers_...) with a more or less unified layout.